Bug 54113 - Review tool should not force various style/build bot links to load in the current window
Summary: Review tool should not force various style/build bot links to load in the cur...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-09 09:44 PST by Oliver Hunt
Modified: 2022-09-29 18:25 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-02-09 09:44:28 PST
I frequently want to look at bot output while reviewing a patch, but the forced in place navigation means that i cannot maintain context, and will lose incomplete comments.
Comment 1 Adam Barth 2011-02-09 11:04:36 PST
I think the problem is that we're using click handlers instead of hyperlinks.
Comment 2 Adam Barth 2011-02-09 12:54:49 PST
Notice the onclick handler here:

http://trac.webkit.org/browser/trunk/Tools/QueueStatusServer/templates/statusbubble.html

We just need to change that to an anchor element and adjust the CSS to keep it looking pretty.
Comment 3 Ahmad Saleem 2022-09-24 05:30:45 PDT
Do we need this and now Status Bubbles are managed on GitHub? Is this still exist? Thanks!
Comment 4 Alexey Proskuryakov 2022-09-29 18:25:41 PDT
This is working as expected in Bugzilla too now.