Bug 54208 - Double-clicking locations of assertions/logs in Visual Studio's Output Window does nothing
Summary: Double-clicking locations of assertions/logs in Visual Studio's Output Window...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 07:31 PST by Adam Roben (:aroben)
Modified: 2011-02-10 11:27 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.89 KB, patch)
2011-02-10 07:32 PST, Adam Roben (:aroben)
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-10 07:31:41 PST
Double-clicking locations of assertions/logs in Visual Studio's Output Window does nothing
Comment 1 Adam Roben (:aroben) 2011-02-10 07:32:57 PST
Created attachment 81979 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-02-10 09:12:39 PST
Comment on attachment 81979 [details]
Patch

What is the reason for having two printf_stderr_common formats? Could you change the existing one and keep it at two code paths instead of three?

If three are needed, a comment is probably in order.
Comment 3 Adam Roben (:aroben) 2011-02-10 09:38:32 PST
(In reply to comment #2)
> (From update of attachment 81979 [details])
> What is the reason for having two printf_stderr_common formats? Could you change the existing one and keep it at two code paths instead of three?
> 
> If three are needed, a comment is probably in order.

I was just trying to be conservative and not change the format for non-Windows platforms. But I can easily change it for all platforms if you thinks that's better.
Comment 4 Alexey Proskuryakov 2011-02-10 10:05:56 PST
I don't know. Maybe change it, and thus make whoever cares about the old format complain and actually add a comment explaining why this format was chosen? You could also check svn history and talk to the author.
Comment 5 Adam Roben (:aroben) 2011-02-10 10:25:17 PST
(In reply to comment #4)
> I don't know. Maybe change it, and thus make whoever cares about the old format complain and actually add a comment explaining why this format was chosen? You could also check svn history and talk to the author.

Here are the changes to the format I can find:

<http://trac.webkit.org/changeset/1271#file3>
Ken Kocienda added stderr output on assertions with the "file:line function" format.

<http://trac.webkit.org/changeset/1339#file3>
Ken Kocienda added the "=======" lines and uppercased "assertion failure"

<http://trac.webkit.org/changeset/1403#file12>
Darin Adler added the parentheses around the location.

<http://trac.webkit.org/changeset/16782#file1>
Darin Adler removed the "=======" lines and added the call to _CrtDbgReport, which uses its own format.

Seems likely we can just change it and see who (if anyone) complains.
Comment 6 Adam Roben (:aroben) 2011-02-10 11:27:39 PST
Committed r78250: <http://trac.webkit.org/changeset/78250>