Bug 54485 - Fix spelling of -inProgramaticScroll
Summary: Fix spelling of -inProgramaticScroll
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on: 23556
Blocks: 54505
  Show dependency treegraph
 
Reported: 2011-02-15 12:06 PST by David Kilzer (:ddkilzer)
Modified: 2011-02-15 15:52 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.79 KB, patch)
2011-02-15 12:06 PST, David Kilzer (:ddkilzer)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-02-15 12:06:17 PST
Created attachment 82497 [details]
Patch

Reviewed by NOBODY (OOPS!).

* WebView/WebDynamicScrollBarsView.h:
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
-inProgramaticScroll.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
---
 4 files changed, 16 insertions(+), 3 deletions(-)
Comment 1 Darin Adler 2011-02-15 12:07:32 PST
Comment on attachment 82497 [details]
Patch

What about callers outside WebKit?
Comment 2 David Kilzer (:ddkilzer) 2011-02-15 12:46:00 PST
(In reply to comment #1)
> (From update of attachment 82497 [details])
> What about callers outside WebKit?

Safari doesn't use it.  I suspect -inProgramaticScroll should have gone in WebDynamicScrollBarsViewInternal.h anyway.

Note that this was added in r72852 for Bug 23556.

<http://trac.webkit.org/changeset/72852>
Comment 3 Darin Adler 2011-02-15 13:06:24 PST
(In reply to comment #2)
> I suspect -inProgramaticScroll should have gone in WebDynamicScrollBarsViewInternal.h anyway.

OK, we should fix that. We could do other research to make sure nothing at Apple is using it, but maybe there hasn’t been time.
Comment 4 David Kilzer (:ddkilzer) 2011-02-15 15:28:08 PST
Committed r78627: <http://trac.webkit.org/changeset/78627>
Comment 5 David Kilzer (:ddkilzer) 2011-02-15 15:52:51 PST
(In reply to comment #3)
> (In reply to comment #2)
> > I suspect -inProgramaticScroll should have gone in WebDynamicScrollBarsViewInternal.h anyway.
> 
> OK, we should fix that. We could do other research to make sure nothing at Apple is using it, but maybe there hasn’t been time.

I filed Bug 54505 about moving it.