54490 – REGRESSION (r78382): No scripts appear in the Web Inspector's Scripts panel on Windows, and many inspector regression tests are failing

Bug 54490 - REGRESSION (r78382): No scripts appear in the Web Inspector's Scripts panel on Windows, and many inspector regression tests are failing

Summary: REGRESSION (r78382): No scripts appear in the Web Inspector's Scripts panel o...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC Windows 7

Importance:	P1 Major
Assignee:	Geoffrey Garen

URL:
Keywords:	InRadar, LayoutTestFailure, PlatformOnly, Regression

Duplicates (1):	54653 (view as bug list)
Depends on:
Blocks:

Reported:	2011-02-15 13:09 PST by Steve Falkenburg
Modified:	2011-03-23 08:36 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (2.90 KB, patch) 2011-03-22 18:52 PDT, Geoffrey Garen	mjs: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Falkenburg 2011-02-15 13:09:58 PST

After http://trac.webkit.org/changeset/78382, these tests started failing:

inspector/console/console-api-on-call-frame.html
inspector/console/console-assert.html
inspector/debugger/debugger-step-over.html
inspector/debugger/debugger-eval-while-paused.html
inspector/debugger/debugger-pause-on-breakpoint.html
inspector/debugger/debugger-eval-on-call-frame.html
inspector/debugger/debugger-step-in.html
inspector/debugger/debugger-scripts.html
inspector/debugger/debugger-pause-in-eval-script.html
inspector/debugger/debugger-proto-property.html
inspector/debugger/debugger-step-out.html
inspector/debugger/debugger-pause-on-exception.html
inspector/debugger/debugger-no-nested-pause.html
inspector/debugger/debugger-cyclic-ref.html
inspector/debugger/debugger-autocontinue-on-syntax-error.html
inspector/debugger/debugger-suspend-active-dom-objects.html
inspector/debugger/debugger-pause-on-debugger-statement.html
inspector/debugger/debugger-expand-scope.html
inspector/debugger/debugger-breakpoints-not-activated-on-reload.html

Comment 1 Steve Falkenburg 2011-02-15 13:21:49 PST

Added tests to skip list in http://trac.webkit.org/changeset/78607

Comment 2 Geoffrey Garen 2011-02-15 13:22:25 PST

<rdar://problem/9006122>

Comment 3 Alexander Pavlov (apavlov) 2011-02-16 10:29:46 PST

In Web Inspector on Windows, I'm not seeing ANY scripts in the Scripts panel (this issue is not observed on other platforms). I believe this is caused by this same issue and breaks the JS debugging experience on Windows altogether.

Comment 4 Adam Roben (:aroben) 2011-02-17 07:33:06 PST

*** Bug 54653 has been marked as a duplicate of this bug. ***

Comment 5 Adam Roben (:aroben) 2011-02-17 07:36:59 PST

Here's the test run where the tests first failed: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9295

Comment 6 Geoffrey Garen 2011-03-22 18:52:08 PDT

Created attachment 86556 [details]
Patch

Comment 7 Maciej Stachowiak 2011-03-22 22:11:57 PDT

Comment on attachment 86556 [details]
Patch

r=me

Comment 8 Geoffrey Garen 2011-03-22 22:21:45 PDT

Committed r81751: <http://trac.webkit.org/changeset/81751>

Comment 9 Adam Roben (:aroben) 2011-03-23 05:41:59 PDT

Geoff, why didn't you remove the Skipped tests from LayoutTests/platform/win/Skipped?

Comment 10 Adam Roben (:aroben) 2011-03-23 08:36:25 PDT

Ah, you did, in r81752. Thanks!