Bug 54808 - Change jsc target to build directly into JavaScriptCore.framework/Resources/jsc
Summary: Change jsc target to build directly into JavaScriptCore.framework/Resources/jsc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-19 09:24 PST by David Kilzer (:ddkilzer)
Modified: 2011-02-19 13:16 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.91 KB, patch)
2011-02-19 09:24 PST, David Kilzer (:ddkilzer)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-02-19 09:24:12 PST
Created attachment 83077 [details]
Patch

Reviewed by NOBODY (OOPS!).

* Configurations/Base.xcconfig: Added
JAVASCRIPTCORE_FRAMEWORKS_DIR variable.
* Configurations/JavaScriptCore.xcconfig: Used
JAVASCRIPTCORE_FRAMEWORKS_DIR to define INSTALL_PATH.
* JavaScriptCore.xcodeproj/project.pbxproj: Set the INSTALL_PATH
for Production configuration of jsc target.
(Copy Into Framework): Removed old build phase.
(Fix Framework Reference): Renamed build phase to "Copy Into
Framework".  Added "set -x" call to make the script print the
commands it is running.  Added code to exit early for Production
builds since this was never intended for them.  Added code to
copy jsc into the JavaScriptCore.framework/Resources directory.
---
 4 files changed, 31 insertions(+), 21 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2011-02-19 10:41:00 PST
Testing details:

- Release and Debug configurations still build jsc into $BUILT_PRODUCTS_DIR, jsc is still copied into $BUILT_PRODUCTS_DIR/JavaScriptCore.framework/Resources/jsc and the loader_path is still updated for $BUILT_PRODUCTS_DIR/JavaScriptCore.framework/Resources/jsc.

- Production builds (via buildit) still build jsc into $SYSTEM_LIBRARY_DIR/Frameworks/JavaScriptCore.framework/Resources/jsc with the loader_path unchanged (as before).
Comment 2 David Kilzer (:ddkilzer) 2011-02-19 13:16:18 PST
Committed r79131: <http://trac.webkit.org/changeset/79131>