Bug 54966 - media/audio-repaint.html and media/media-document-audio-repaint.html failing on Windows since they were added
Summary: media/audio-repaint.html and media/media-document-audio-repaint.html failing ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/results/Windo...
Keywords: InRadar, LayoutTestFailure, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-02-22 09:10 PST by Adam Roben (:aroben)
Modified: 2011-02-23 08:03 PST (History)
3 users (show)

See Also:


Attachments
Actual pixel results from audio-repaint.html (26.62 KB, image/png)
2011-02-22 09:11 PST, Adam Roben (:aroben)
no flags Details
Expected pixel results from audio-repaint.html (34.48 KB, image/png)
2011-02-22 09:11 PST, Adam Roben (:aroben)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-22 09:10:17 PST
media/audio-repaint.html and media/media-document-audio-repaint.html have been failing on Windows since they were added in r79318. See the URL for an example.
Comment 1 Adam Roben (:aroben) 2011-02-22 09:11:09 PST
Created attachment 83329 [details]
Actual pixel results from audio-repaint.html
Comment 2 Adam Roben (:aroben) 2011-02-22 09:11:27 PST
Created attachment 83330 [details]
Expected pixel results from audio-repaint.html
Comment 3 Adam Roben (:aroben) 2011-02-22 09:12:01 PST
From IRC:

<jernoble> aroben: it looks like it's attempting to draw the new-style controls, but using the old mediaControls.css rules.
<jernoble> aroben: if you run your build results against safari (instead of drt) does everything look normal?
<jernoble> aroben: i.e. could this be a DRT bug?
<aroben> jernoble: yes
<aroben> jernoble: my guess is this has to do with DRT setting the "use Mac-style controls" preference
Comment 4 Adam Roben (:aroben) 2011-02-22 09:17:08 PST
Expected failure results landed in r79328.
Comment 5 Adam Roben (:aroben) 2011-02-22 09:17:39 PST
<rdar://problem/9036342>
Comment 6 Ryosuke Niwa 2011-02-22 20:34:16 PST
(In reply to comment #4)
> Expected failure results landed in r79328.

I don't think these expected results are correct.  Tests are failing both on Windows XP and Windows 7 bots.
Comment 7 Ryosuke Niwa 2011-02-22 20:45:59 PST
Committed r79392: <http://trac.webkit.org/changeset/79392>
Comment 8 Ryosuke Niwa 2011-02-22 21:49:59 PST
Committed r79400: <http://trac.webkit.org/changeset/79400>
Comment 9 Adam Roben (:aroben) 2011-02-23 08:03:42 PST
(In reply to comment #6)
> (In reply to comment #4)
> > Expected failure results landed in r79328.
> 
> I don't think these expected results are correct.  Tests are failing both on Windows XP and Windows 7 bots.

The tests were changed in r79359. Thanks for updating the Windows results!