Bug 55365 - REGRESSION (r79040): WebKit2: Large portions of pages with plugins paint black
Summary: REGRESSION (r79040): WebKit2: Large portions of pages with plugins paint black
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: http://dictionary.reference.com/brows...
Keywords: InRadar, PlatformOnly, Regression
Depends on:
Blocks:
 
Reported: 2011-02-28 05:19 PST by Adam Roben (:aroben)
Modified: 2011-02-28 08:30 PST (History)
3 users (show)

See Also:

Attachments
Pass the right dirty rect to Plugin::paint (18.31 KB, patch)
2011-02-28 05:21 PST, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-28 05:19:33 PST 
To reproduce (in a build with the fix for bug 55364):

1. Launch MiniBrowser
2. Go to http://dictionary.reference.com/browse/miffy

Most of the page is black.
Comment 1 Adam Roben (:aroben) 2011-02-28 05:19:41 PST 
<rdar://problem/9031089>
Comment 2 Adam Roben (:aroben) 2011-02-28 05:21:38 PST 
Created attachment 84043 [details]
Pass the right dirty rect to Plugin::paint
Comment 3 WebKit Review Bot 2011-02-28 05:24:17 PST 
Attachment 84043 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Tools/DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp:40:  The parameter name "saved" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Roben (:aroben) 2011-02-28 05:25:43 PST 
Comment on attachment 84043 [details]
Pass the right dirty rect to Plugin::paint

View in context: https://bugs.webkit.org/attachment.cgi?id=84043&action=review

>> Tools/DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp:40
>> +    virtual NPError NPP_New(NPMIMEType pluginType, uint16_t mode, int16_t argc, char *argn[], char *argv[], NPSavedData *saved);
> 
> The parameter name "saved" adds no information, so it should be removed.  [readability/parameter_name] [5]

Fixed. Also removed "pluginType", and fixed * placement.
Comment 5 Adam Roben (:aroben) 2011-02-28 07:33:21 PST 
Committed r79863: <http://trac.webkit.org/changeset/79863>
Comment 6 Simon Fraser (smfr) 2011-02-28 08:30:47 PST 
Thanks for fixing and all the testing work, Adam!