Bug 55513 - REGRESSION (r79925): Lots of plugins tests crashing in NetscapePlugin::initialize on Windows
Summary: REGRESSION (r79925): Lots of plugins tests crashing in NetscapePlugin::initia...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL: http://build.webkit.org/results/Windo...
Keywords: InRadar, LayoutTestFailure, PlatformOnly, Regression
Depends on:
Blocks:
 
Reported: 2011-03-01 15:00 PST by Adam Roben (:aroben)
Modified: 2011-03-02 00:58 PST (History)
5 users (show)

See Also:

Attachments
Make the PLUGIN_ARCHITECTURE() macro work with MSVC (12.71 KB, patch)
2011-03-01 15:32 PST, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-01 15:00:11 PST 
Lots of plugins tests are crashing in NetscapePlugin::initialize on Windows. See the URL for crash logs. This seems to have started happening somewhat recently, though I'm not exactly sure when.
Comment 1 Adam Roben (:aroben) 2011-03-01 15:00:31 PST 
<rdar://problem/9069189>
Comment 2 Adam Roben (:aroben) 2011-03-01 15:02:52 PST 
Looks like PLUGIN_ARCHITECTURE(WIN) isn't true on Windows.
Comment 3 Adam Roben (:aroben) 2011-03-01 15:32:01 PST 
Created attachment 84310 [details]
Make the PLUGIN_ARCHITECTURE() macro work with MSVC
Comment 4 Anders Carlsson 2011-03-01 15:33:37 PST 
Comment on attachment 84310 [details]
Make the PLUGIN_ARCHITECTURE() macro work with MSVC

View in context: https://bugs.webkit.org/attachment.cgi?id=84310&action=review

> Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp:36
> +#error Unknown platform

Can this say "Unknown plug-in architecture" instead?
Comment 5 Adam Roben (:aroben) 2011-03-01 15:39:14 PST 
Committed r80051: <http://trac.webkit.org/changeset/80051>
Comment 6 Adam Roben (:aroben) 2011-03-01 15:46:24 PST 
Incorporated Anders's comment

Committed r80053: <http://trac.webkit.org/changeset/80053>
Comment 7 WebKit Review Bot 2011-03-01 16:33:19 PST 
http://trac.webkit.org/changeset/80051 might have broken Qt Linux Release
The following tests are not passing:
fast/canvas/canvas-strokePath-gradient-shadow.html
Comment 8 Balazs Kelemen 2011-03-02 00:58:11 PST 
My fault. Thanks for the fix Adam.