Bug 55581 - Test results don't get uploaded if test-result-archive fails to delete the results directory
Summary: Test results don't get uploaded if test-result-archive fails to delete the re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/builders/Wind...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 08:30 PST by Adam Roben (:aroben)
Modified: 2011-03-10 12:58 PST (History)
3 users (show)

See Also:


Attachments
Ignore errors from files being held open when creating a test result archive (1.80 KB, patch)
2011-03-10 12:45 PST, Adam Roben (:aroben)
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-02 08:30:55 PST
Test results don't get uploaded if test-result-archive fails to delete the results directory. Here's an example of this happening on apple-windows-13:

http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/25891/steps/archive-test-results/logs/stdio

We should probably make the script just ignore this error.
Comment 1 Adam Roben (:aroben) 2011-03-02 08:53:34 PST
It looks like there was a websocket server process still holding onto the files that couldn't be deleted. I've filed bug 55583 to cover the fact that that process was sticking around.

I still think we should fix this bug.
Comment 2 Adam Roben (:aroben) 2011-03-10 12:45:16 PST
Created attachment 85375 [details]
Ignore errors from files being held open when creating a test result archive
Comment 3 Mark Rowe (bdash) 2011-03-10 12:47:38 PST
Comment on attachment 85375 [details]
Ignore errors from files being held open when creating a test result archive

r=me.  It would be nice if we could somehow detect the stale files and clean them up (move them to a different directory perhaps?), but this is certainly a big improvement.
Comment 4 Adam Roben (:aroben) 2011-03-10 12:58:02 PST
Committed r80748: <http://trac.webkit.org/changeset/80748>