Bug 55599 - r80079 caused incremental Windows builds to fail
Summary: r80079 caused incremental Windows builds to fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 12:01 PST by Adam Roben (:aroben)
Modified: 2011-03-02 12:49 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.90 KB, patch)
2011-03-02 12:02 PST, Adam Roben (:aroben) 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-02 12:01:22 PST 
r80079 caused incremental Windows builds to fail
Comment 1 Adam Roben (:aroben) 2011-03-02 12:02:19 PST 
Here's the build that failed: http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/31688

The errors were:

10>WebKit2WebProcess.res : fatal error LNK1241: resource file WebKit2WebProcess.res already specified
11>FindSafari.res : fatal error LNK1241: resource file FindSafari.res already specified
Comment 2 Adam Roben (:aroben) 2011-03-02 12:02:48 PST 
Created attachment 84445 [details]
Patch
Comment 3 Tony Chang 2011-03-02 12:43:38 PST 
Comment on attachment 84445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84445&action=review

> Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:24
> +    for extension in ['manifest', 'pch', 'res']:

Nit: Using a tuple instead of a list is a bit more efficient.
Comment 4 Adam Roben (:aroben) 2011-03-02 12:49:40 PST 
Committed r80158: <http://trac.webkit.org/changeset/80158>