Bug 56109 - run-webkit-tests sometimes times after fast/text/large-text-composed-char-dos.html fails (due to PrettyPatch hanging?)
Summary: run-webkit-tests sometimes times after fast/text/large-text-composed-char-dos...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/builders/Wind...
Keywords: InRadar, MakingBotsRed, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-03-10 08:51 PST by Adam Roben (:aroben)
Modified: 2011-03-10 12:26 PST (History)
0 users

See Also:


Attachments
Don't search for intra-line diffs in really long lines (2.51 KB, patch)
2011-03-10 12:13 PST, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-10 08:51:12 PST
run-webkit-tests is sometimes hanging and getting killed by buildbot on Windows XP Debug (Tests). It seems to (always?) happen after fast/text/large-text-composed-char-dos.html fails. Here are some examples of it happening on all three of our slaves:

http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/26168/steps/layout-test/logs/stdio
http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/26182/steps/layout-test/logs/stdio
http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/26172/steps/layout-test/logs/stdio
Comment 1 Jessie Berlin 2011-03-10 09:17:36 PST
<rdar://problem/9114976>
Comment 2 Adam Roben (:aroben) 2011-03-10 09:49:44 PST
It looks like the pretty diff output file is getting held open: http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/26164/steps/archive-test-results/logs/stdio

This indicates that prettify.rb is hanging.
Comment 3 Adam Roben (:aroben) 2011-03-10 09:50:40 PST
The fact that the test results are failing to get uploaded is covered by bug 55581.
Comment 4 Adam Roben (:aroben) 2011-03-10 11:55:01 PST
I logged into apple-windows-13 and ruby.exe was indeed still running.
Comment 5 Adam Roben (:aroben) 2011-03-10 11:56:11 PST
I can reproduce on my own machine.
Comment 6 Adam Roben (:aroben) 2011-03-10 11:57:32 PST
Killing ruby gave me this output:

./Websites/bugs.webkit.org/PrettyPatch/diff.rb:115:in `find_match': Interrupt
        from ./Websites/bugs.webkit.org/PrettyPatch/diff.rb:114:in `each'
        from ./Websites/bugs.webkit.org/PrettyPatch/diff.rb:114:in `find_match'
        from ./Websites/bugs.webkit.org/PrettyPatch/diff.rb:110:in `upto'
        from ./Websites/bugs.webkit.org/PrettyPatch/diff.rb:110:in `find_match'
        from ./Websites/bugs.webkit.org/PrettyPatch/diff.rb:88:in `recursively_find_matching_blocks'
        from ./Websites/bugs.webkit.org/PrettyPatch/diff.rb:83:in `matching_blocks'
        from ./Websites/bugs.webkit.org/PrettyPatch/diff.rb:38:in `operations'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:729:in `initialize'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:728:in `each'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:728:in `initialize'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:726:in `each'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:726:in `initialize'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:767:in `new'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:767:in `parse'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:767:in `collect'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:767:in `parse'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:509:in `initialize'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:583:in `new'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:583:in `parse'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:583:in `collect'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:583:in `parse'
        from ./Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:15:in `prettify'
        from Websites/bugs.webkit.org/PrettyPatch//prettify.rb:26
.Use of uninitialized value $convertedPath in substitution (s///) at ../Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/old-run-webkit-tests line 1872, <inFH> line 5.
Comment 7 Adam Roben (:aroben) 2011-03-10 12:01:54 PST
We should probably bail on finding intra-line diffs on extremely large lines so we don't hang like this.
Comment 8 Adam Roben (:aroben) 2011-03-10 12:13:26 PST
Created attachment 85367 [details]
Don't search for intra-line diffs in really long lines
Comment 9 David Kilzer (:ddkilzer) 2011-03-10 12:17:38 PST
Comment on attachment 85367 [details]
Don't search for intra-line diffs in really long lines

r=me
Comment 10 Adam Roben (:aroben) 2011-03-10 12:26:03 PST
Committed r80741: <http://trac.webkit.org/changeset/80741>
Comment 11 Adam Roben (:aroben) 2011-03-10 12:26:26 PST
Looks like this can happen on the Release bots, too.