Bug 56304 - REGRESSION(r80892): 100,000+ leaks seen on the build bot
Summary: REGRESSION(r80892): 100,000+ leaks seen on the build bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/results/SnowL...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 05:14 PDT by Mark Rowe (bdash)
Modified: 2011-03-14 13:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.24 KB, patch)
2011-03-14 05:24 PDT, Mark Rowe (bdash) 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2011-03-14 05:14:19 PDT 
After r80892 there are over 100,000 leaks reported on the leaks bot.  Prior to that revision the number was much, much smaller.
Comment 1 Mark Rowe (bdash) 2011-03-14 05:15:50 PDT 
The reason for this is that r80892 adds duplicate static function entries to the JSClassDefinition in DumpRenderTree’s LayoutTestController.cpp.  This appears to cause JavaScriptCore to leak each of the duplicates.  This is triggered every time the window object is cleared (once per frame per test?).
Comment 2 Mark Rowe (bdash) 2011-03-14 05:24:31 PDT 
Created attachment 85668 [details]
Patch

The explicit calls to StringImpl::ref seem as though they will also result in leaks as there are no matching calls to StringImpl::deref anywhere.  The patch removes those as well as fixing the bigger issue of the leaked duplicate entries.
Comment 3 Mark Rowe (bdash) 2011-03-14 13:41:17 PDT 
Fixed in r81051.