We should enable -Werror on ANGLE to catch compiler issues. There are a few fixes for clang that must be addressed first.
Created attachment 85736 [details] Patch 5/5: Enable -Werror on ANGLE Posting the last one first to make sure gcc-4.2/llvm-gcc-4.2 still builds with this change.
Created attachment 85737 [details] Patch 1/5: Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch
Created attachment 85738 [details] Patch 2/5: Fix clang warning: ParseHelper.cpp:264:13: warning: 8 enumeration values not handled in switch
Created attachment 85739 [details] Patch 3/5: Fix clang warnings: Intermediate.cpp: warning: '&&' within '||'
Created attachment 85740 [details] Patch 4/5: Fix clang warnings in PoolAlloc.cpp
Attachment 85739 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Sour..." exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1008: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1020: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
This should be fixed upstream ANGLE. If you commit it here, after a ANGLE roll in the future, your change will be lost. I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit.
(In reply to comment #7) > This should be fixed upstream ANGLE. If you commit it here, after a ANGLE roll in the future, your change will be lost. > > I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. So you don't merge changes from ANGLE into WebKit--you just land new code and delete whatever local changes were made?
(In reply to comment #7) > I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. I'll upload the patches upstream as well.
Comment on attachment 85737 [details] Patch 1/5: Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=124>
Comment on attachment 85738 [details] Patch 2/5: Fix clang warning: ParseHelper.cpp:264:13: warning: 8 enumeration values not handled in switch Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=125>
Comment on attachment 85739 [details] Patch 3/5: Fix clang warnings: Intermediate.cpp: warning: '&&' within '||' Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=126>
Comment on attachment 85740 [details] Patch 4/5: Fix clang warnings in PoolAlloc.cpp Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=127>
Patch 5/5 (Attachment 85736 [details]) is now blocked on the upstream patches landing, then ANGLE being updated.
Attachment 85736 [details] did not build on mac: Build output: http://queues.webkit.org/results/8175479
Comment on attachment 85736 [details] Patch 5/5: Enable -Werror on ANGLE I support this product and or service (assuming it builds).
(In reply to comment #8) > (In reply to comment #7) > > This should be fixed upstream ANGLE. If you commit it here, after a ANGLE roll in the future, your change will be lost. > > > > I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. > > So you don't merge changes from ANGLE into WebKit--you just land new code and delete whatever local changes were made? Yes. That's at least what we've done so far.
(In reply to comment #14) > Patch 5/5 (Attachment 85736 [details]) is now blocked on the upstream patches landing, then ANGLE being updated. Filed Bug 56396 to update ANGLE to at least r575, which will pick up the necessary fixes to enable -Werror.
Part 1 of 2: Committed r85761: <http://trac.webkit.org/changeset/85761>
Part 2 of 2: Committed r85762: <http://trac.webkit.org/changeset/85762>