It would be useful for Leaks Viewer to show how many bytes were leaked. (Currently it only shows how many allocations were leaked.) This would allow us to prioritize bigger leaks over smaller ones.
I think we could change the Self and Total columns to show bytes, and add the Calls column to show number of allocations.
Created attachment 86139 [details] Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
Comment on attachment 86139 [details] Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer View in context: https://bugs.webkit.org/attachment.cgi?id=86139&action=review r=me, Nice! > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:39 > + var match = /Leak:.*\ssize=(\d+)\s/.exec(line); Nit: It might be worth adding a start anchor? /^Leak.../ I don't think you'd ever get a false positive with the '=' string, but it might help matching against long lines. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:88 > + childNode.selfTime += leak.size; > + childNode.totalTime += leak.size; > + ++childNode.numberOfCalls; These property names no longer make sense, and could be renamed in the Worker code and converted later. But I understand your concerns about performance. So I'm okay with these.
Committed r81445: <http://trac.webkit.org/changeset/81445>
And added the regexp anchor Committed r81448: <http://trac.webkit.org/changeset/81448>