Bug 56402 - REGRESSION (WebKit2): keygen element doesn't work
Summary: REGRESSION (WebKit2): keygen element doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-15 12:49 PDT by Alexey Proskuryakov
Modified: 2011-03-15 14:16 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (62.12 KB, patch)
2011-03-15 13:32 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-03-15 12:49:30 PDT 
It used to work in WK1 in Mac.

<rdar://problem/9006545>
Comment 1 Alexey Proskuryakov 2011-03-15 13:32:41 PDT 
Created attachment 85850 [details]
proposed fix
Comment 2 Darin Adler 2011-03-15 13:36:03 PDT 
Comment on attachment 85850 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=85850&action=review

> Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.mm:2
> + * Copyright (C) 2005, 2011 Apple Computer, Inc.  All rights reserved.

Should change company name to Apple Inc.
Comment 3 WebKit Review Bot 2011-03-15 13:37:09 PDT 
Attachment 85850 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/platform/mac/SSLKeyGeneratorMac.cpp:49:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alexey Proskuryakov 2011-03-15 14:16:15 PDT 
Committed <http://trac.webkit.org/changeset/81173>.