Bug 56571 - First argument passed to WebKit.exe is ignored by Safari
Summary: First argument passed to WebKit.exe is ignored by Safari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: PlatformOnly
: 63389 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-17 10:32 PDT by Adam Roben (:aroben)
Modified: 2012-01-05 11:57 PST (History)
2 users (show)

See Also:


Attachments
Stop using explicit memory management in WebKitLauncherWin (4.78 KB, patch)
2012-01-05 10:36 PST, Adam Roben (:aroben)
sfalken: review+
Details | Formatted Diff | Diff
Prepend Safari.exe's path to the command-line passed to CreateProcess (2.71 KB, patch)
2012-01-05 10:37 PST, Adam Roben (:aroben)
sfalken: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-17 10:32:10 PDT
To reproduce:

1. Launch Safari
2. Run WebKit.exe /newProcess. Note in Task Manager that only one Safari process is running.
3. Run WebKit.exe foo /newProcess. Note in Task Manager that two Safari processes are now running.

It looks like the first argument that's passed to WebKit.exe is not sent to Safari correctly. I think we're misusing the CreateProcess API.
Comment 1 Adam Roben (:aroben) 2011-06-26 11:15:02 PDT
*** Bug 63389 has been marked as a duplicate of this bug. ***
Comment 2 Adam Roben (:aroben) 2012-01-05 10:36:59 PST
Created attachment 121296 [details]
Stop using explicit memory management in WebKitLauncherWin
Comment 3 Adam Roben (:aroben) 2012-01-05 10:37:04 PST
Created attachment 121297 [details]
Prepend Safari.exe's path to the command-line passed to CreateProcess
Comment 4 Adam Roben (:aroben) 2012-01-05 11:57:29 PST
Committed r104190: <http://trac.webkit.org/changeset/104190>