Bug 56578 - Web Inspector: http/tests/inspector/network tests sometimes fail on Leopard Intel Release (Tests) and SnowLeopard Intel Leaks
Summary: Web Inspector: http/tests/inspector/network tests sometimes fail on Leopard I...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/results/Leopa...
Keywords: LayoutTestFailure
Depends on: 56769
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-17 11:40 PDT by Adam Roben (:aroben)
Modified: 2011-03-21 15:02 PDT (History)
16 users (show)

See Also:


Attachments
Patch that fixes and re-enables tests. (9.22 KB, patch)
2011-03-21 04:51 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-17 11:40:57 PDT
http/tests/inspector/network/network-size.html failed once on Leopard Intel Release (Tests). See the URL for the failure diff.
Comment 1 Adam Roben (:aroben) 2011-03-17 11:42:42 PDT
Also failed on SnowLeopard Intel Leaks:

http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r81363%20(15641)/results.html
Comment 4 Adam Roben (:aroben) 2011-03-17 13:49:18 PDT
Added to the mac Skipped file

Committed r81382: <http://trac.webkit.org/changeset/81382>
Comment 5 Adam Roben (:aroben) 2011-03-17 14:41:52 PDT
After skipping network-size.html, network-timing.html started failing:

http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r81385%20(29911)/http/tests/inspector/network/network-timing-pretty-diff.html

Pavel Feldman says we should just skip these tests for now, since they are unreliable.
Comment 6 Adam Roben (:aroben) 2011-03-17 15:04:41 PDT
Disabled the tests

Committed r81391: <http://trac.webkit.org/changeset/81391>
Comment 7 Vsevolod Vlasov 2011-03-21 04:51:48 PDT
Created attachment 86307 [details]
Patch that fixes and re-enables tests.
Comment 8 Adam Roben (:aroben) 2011-03-21 07:21:27 PDT
Thanks for looking into this, Vsevolod!
Comment 9 WebKit Commit Bot 2011-03-21 12:50:07 PDT
Comment on attachment 86307 [details]
Patch that fixes and re-enables tests.

Clearing flags on attachment: 86307

Committed r81601: <http://trac.webkit.org/changeset/81601>
Comment 10 WebKit Commit Bot 2011-03-21 12:50:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 WebKit Review Bot 2011-03-21 15:02:05 PDT
http://trac.webkit.org/changeset/81601 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
http/tests/inspector/network/network-size.html