webkit-patch gives no hint when dcommit fail, which makes diagnosis hard.
Created attachment 88278 [details] Patch
Comment on attachment 88278 [details] Patch Rather than using isinstance, can we add a ScriptError __str__ method that prints the output?
Created attachment 88298 [details] Patch
Hi Tony, thank you for your prompt review! > (From update of attachment 88278 [details]) > Rather than using isinstance, can we add a ScriptError __str__ method that prints the output? Sure. I updated to do this.
Committed r82978: <http://trac.webkit.org/changeset/82978>
(In reply to comment #5) > Committed r82978: <http://trac.webkit.org/changeset/82978> Looks like this broke SL and Windows webkit-py test: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/27740/steps/webkitpy-test/logs/stdio http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/11247/steps/webkitpy-test/logs/stdio
I tried fixing this on the bots, but didn't succeed. We need a python2.5 test environment.
Attachment 88298 [details] was posted by a committer and has review+, assigning to Hajime Morita for commit.
This patch was landed, but rolled out due to mysterious regression. I have no idea for dealing with it.
Comment on attachment 88298 [details] Patch Obsoleting the patch since it has some compatibility problem.
Comment on attachment 88298 [details] Patch Cleared Adam Barth's review+ from obsolete attachment 88298 [details] so that this bug does not appear in http://webkit.org/pending-commit.