To reproduce: 1. Go to <http://build.webkit.org/LeaksViewer/> 2. Click on a recent build The leaks from that build never load.
r82734 changed the "view results" links to point to results.html. Leaks Viewer expects them to point to the directory that contains results.html. Should be easy to fix.
Created attachment 88290 [details] Strip off /results.html from results URLs before trying to load leaks files from them
Comment on attachment 88290 [details] Strip off /results.html from results URLs before trying to load leaks files from them View in context: https://bugs.webkit.org/attachment.cgi?id=88290&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:65 > + var url = step.urls["view results"]; > + buildInfo.url = self._buildbotBaseURL + url.replace(/\/results\.html$/, "") + "/"; If all the build bots point to ".../results.html" you only need to chop off the results.html part and not add the slash. But I think the current approach works well because it always ensures a slash at the end.
Comment on attachment 88290 [details] Strip off /results.html from results URLs before trying to load leaks files from them View in context: https://bugs.webkit.org/attachment.cgi?id=88290&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:65 >> + buildInfo.url = self._buildbotBaseURL + url.replace(/\/results\.html$/, "") + "/"; > > If all the build bots point to ".../results.html" you only need to chop off the results.html part and not add the slash. But I think the current approach works well because it always ensures a slash at the end. That was exactly my thinking. (Old builds don't include the "/results.html", but of course that isn't a concern for RecentBuildsLoader.)
Committed r82967: <http://trac.webkit.org/changeset/82967>