RESOLVED INVALID 59705
WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called 
https://bugs.webkit.org/show_bug.cgi?id=59705
Summary WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called
David Kilzer (:ddkilzer)
Reported 2011-04-28 09:19:28 PDT
Created attachment 91502 [details] Patch Reviewed by NOBODY (OOPS!). * wtf/mac/MainThreadMac.mm: (WTF::postTimer): Use RetainPtr to plug the leak. --- 2 files changed, 12 insertions(+), 1 deletions(-)
Attachments
Patch (1.61 KB, patch)
2011-04-28 09:19 PDT, David Kilzer (:ddkilzer) 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-04-28 09:20:53 PDT
Comment on attachment 91502 [details] Patch Good catch!
WebKit Review Bot
Comment 2 2011-04-28 09:21:53 PDT
Attachment 91502 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 3 2011-04-28 09:22:25 PDT
This regressed in r55816 for Bug 35943. <http://trac.webkit.org/changeset/55816>
David Kilzer (:ddkilzer)
Comment 4 2011-04-28 09:40:38 PDT
Committed r85195: <http://trac.webkit.org/changeset/85195>
David Kilzer (:ddkilzer)
Comment 5 2011-04-28 16:54:53 PDT
This needs to be rolled out. It causes crashes on Lion.
David Kilzer (:ddkilzer)
Comment 6 2011-04-28 16:56:02 PDT
<rdar://problem/9355811>
Darin Adler
Comment 7 2011-04-28 17:00:07 PDT
Comment on attachment 91502 [details] Patch I don’t think this fix is correct. The timerFired function releases the timer when it fires, so as far as I can tell there is no leak here.
David Kilzer (:ddkilzer)
Comment 8 2011-04-28 17:07:57 PDT
(In reply to comment #7) > (From update of attachment 91502 [details]) > I don’t think this fix is correct. The timerFired function releases the timer when it fires, so as far as I can tell there is no leak here. Ahh...that's kind of strange, but it works. Rolled out in r85265. <http://trac.webkit.org/changeset/85265> Closing as RESOLVED/INVALID.
Note You need to log in before you can comment on or make changes to this bug.