Created attachment 91750 [details] Patch Reviewed by NOBODY (OOPS!). Source/WebCore: * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Set the priority on the request if HTTP pipelining is enabled. (WebCore::ResourceRequest::doUpdateResourceRequest): Read the priority from the request if HTTP pipelining is enabled. (readBooleanPreference): Enable code when compiling with USE(CFNETWORK). (WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto. Source/WebKit/win: * Interfaces/IWebViewPrivate.idl: (IWebViewPrivate::httpPipeliningEnabled): Added declaration. (IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration. * WebView.cpp: (WebView::httpPipeliningEnabled): Added. (WebView::setHTTPPipeliningEnabled): Added. * WebView.h: (WebView::httpPipeliningEnabled): Added declaration. (WebView::setHTTPPipeliningEnabled): Added declaration. WebKitLibraries: * win/include/WebKitSystemInterface/WebKitSystemInterface.h: (wkGetHTTPPipeliningPriority): Added declaration. (wkSetHTTPPipeliningMaximumPriority): Added declaration. (wkSetHTTPPipeliningPriority): Added declaration. --- 8 files changed, 90 insertions(+), 2 deletions(-)
<rdar://problem/8924448>
Attachment 91750 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 WebKitLibraries/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/win/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/win/WebView.h:832: The parameter name "enabled" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 91750 [details] did not build on win: Build output: http://queues.webkit.org/results/8529018
Comment on attachment 91750 [details] Patch This seems fine. You just need to update your ChangeLogs (and be sure toe update WebKitLibraires on windows before you land).
(In reply to comment #4) > (From update of attachment 91750 [details]) > This seems fine. You just need to update your ChangeLogs (and be sure toe update WebKitLibraires on windows before you land). Actually, I need to make webkit-patch adopt my workflow. Bug 57242. Entering bug numbers in ChangeLogs is just busywork (which I'll do manually until I fix webkit-patch).
Part 1 of 2: Committed r85611: <http://trac.webkit.org/changeset/85611>
(In reply to comment #3) > Attachment 91750 [details] did not build on win: > Build output: http://queues.webkit.org/results/8529018 4>..\platform\network\cf\ResourceRequestCFNet.cpp(254) : error C3861: 'wkSetHTTPPipeliningMinimumFastLanePriority': identifier not found
Created attachment 92093 [details] Patch v2 This should build now on the Windows buildbot.
Attachment 92093 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/win/WebView.h:837: The parameter name "enabled" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #9) > Attachment 92093 [details] did not pass style-queue: > > Source/WebKit/win/WebView.h:837: The parameter name "enabled" adds no information, so it should be removed. [readability/parameter_name] [5] Fixed locally.
Part 2 of 2: Committed r85684: <http://trac.webkit.org/changeset/85684>