Bug 60374 - Adding parameters to ScheduleChildWindowGeometryUpdate message is tedious
Summary: Adding parameters to ScheduleChildWindowGeometryUpdate message is tedious
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks: 60285
  Show dependency treegraph
 
Reported: 2011-05-06 09:20 PDT by Adam Roben (:aroben)
Modified: 2011-05-06 10:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (21.93 KB, patch)
2011-05-06 09:21 PDT, Adam Roben (:aroben)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-05-06 09:20:39 PDT
Adding parameters to ScheduleChildWindowGeometryUpdate message is tedious
Comment 1 Adam Roben (:aroben) 2011-05-06 09:21:26 PDT
Created attachment 92588 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-06 09:24:06 PDT
Attachment 92588 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Shared/win/WindowGeometry.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2011-05-06 10:31:07 PDT
Committed r85958: <http://trac.webkit.org/changeset/85958>