Bug 60392 - Leopard Intel Release (NRWT) shouldn't be a core builder
Summary: Leopard Intel Release (NRWT) shouldn't be a core builder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-06 11:49 PDT by Adam Roben (:aroben)
Modified: 2011-05-13 10:40 PDT (History)
2 users (show)

See Also:


Attachments
Exclude the Leopard NRWT bot from the core builder set (2.87 KB, patch)
2011-05-13 08:00 PDT, Adam Roben (:aroben)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-05-06 11:49:16 PDT
Leopard Intel Release (NRWT) is currently a core builder. But we don't currently expect it to be green. It's more a proof-of-concept bot to help us shake out NRWT issues. So we should remove it from the core set.
Comment 1 Dirk Pranke 2011-05-06 20:08:37 PDT
I'm totally fine with this. what needs to be done to make it non-core?
Comment 2 Eric Seidel (no email) 2011-05-08 14:02:49 PDT
Yeah, I don't think anyone has any objections, just no one has bothered to do it yet. :)

The core builders code (which is old!) is here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py#L287

For whatever reason when I added the core builder code I copied the regexps to the unittests (I think I though it made the tests more explicit, but mostly its just confused people).  They're here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py#L273

Both need to be changed.
Comment 3 Adam Roben (:aroben) 2011-05-13 08:00:28 PDT
Created attachment 93453 [details]
Exclude the Leopard NRWT bot from the core builder set
Comment 4 Adam Roben (:aroben) 2011-05-13 10:40:31 PDT
Committed r86445: <http://trac.webkit.org/changeset/86445>