Bug 60776 - It's hard to write tests that check plugin window geometry
Summary: It's hard to write tests that check plugin window geometry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks: 60194
  Show dependency treegraph
 
Reported: 2011-05-13 09:16 PDT by Adam Roben (:aroben)
Modified: 2011-05-13 10:25 PDT (History)
2 users (show)

See Also:


Attachments
Move code required for most tests of plugin window geometry into a base class (16.00 KB, patch)
2011-05-13 09:18 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move code required for most tests of plugin window geometry into a base class (20.67 KB, patch)
2011-05-13 09:20 PDT, Adam Roben (:aroben)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-05-13 09:16:24 PDT
It's hard to write tests that check plugin window geometry
Comment 1 Adam Roben (:aroben) 2011-05-13 09:18:37 PDT
Created attachment 93462 [details]
Move code required for most tests of plugin window geometry into a base class
Comment 2 Adam Roben (:aroben) 2011-05-13 09:20:41 PDT
Created attachment 93463 [details]
Move code required for most tests of plugin window geometry into a base class
Comment 3 WebKit Review Bot 2011-05-13 09:22:23 PDT
Attachment 93462 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Roben (:aroben) 2011-05-13 10:25:48 PDT
Committed r86441: <http://trac.webkit.org/changeset/86441>