Bug 61060 - TestFailures page should provide links to regression ranges in Trac
Summary: TestFailures page should provide links to regression ranges in Trac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/TestFailures/
Keywords: InRadar, ToolsHitList
Depends on:
Blocks:
 
Reported: 2011-05-18 08:45 PDT by Adam Roben (:aroben)
Modified: 2011-06-24 12:38 PDT (History)
0 users

See Also:


Attachments
Add links to regression ranges in Trac to the TestFailures page (7.62 KB, patch)
2011-06-24 11:43 PDT, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-05-18 08:45:02 PDT
The TestFailures page shows the revision range in which a given test started failing. It also has links to the last-known passing revision and the first-known failing revision in Trac.

It would be great to have a link to Trac that showed a timeline of all revisions in the regression range as well.
Comment 1 Adam Roben (:aroben) 2011-05-18 08:45:07 PDT
<rdar://problem/9452153>
Comment 2 Adam Roben (:aroben) 2011-06-24 11:43:17 PDT
Created attachment 98519 [details]
Add links to regression ranges in Trac to the TestFailures page
Comment 3 David Kilzer (:ddkilzer) 2011-06-24 12:29:09 PDT
Comment on attachment 98519 [details]
Add links to regression ranges in Trac to the TestFailures page

View in context: https://bugs.webkit.org/attachment.cgi?id=98519&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:32
> +        return addQueryParametersToURL(this.baseURL + 'log/' + path, { rev: endRevision, stop_rev: startRevision });

Kind of funny that stop_rev == startRevision, but maybe trac's terminology is backwards?
Comment 4 Adam Roben (:aroben) 2011-06-24 12:32:51 PDT
Comment on attachment 98519 [details]
Add links to regression ranges in Trac to the TestFailures page

View in context: https://bugs.webkit.org/attachment.cgi?id=98519&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:32
>> +        return addQueryParametersToURL(this.baseURL + 'log/' + path, { rev: endRevision, stop_rev: startRevision });
> 
> Kind of funny that stop_rev == startRevision, but maybe trac's terminology is backwards?

log is a backward-looking UI, so it starts at a particular revision and goes backward in time from there.
Comment 5 Adam Roben (:aroben) 2011-06-24 12:38:47 PDT
Committed r89695: <http://trac.webkit.org/changeset/89695>