The TestFailures page currently lists all testers, regardless of whether any tests are failing on them or not. We should only list testers that currently have failing tests.
<rdar://problem/9460533>
Created attachment 94605 [details] Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
Comment on attachment 94605 [details] Make TestFailures show how many tests are failing on each tester, and omit testers with no failures View in context: https://bugs.webkit.org/attachment.cgi?id=94605&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:68 > + getResource(self.buildbot.baseURL + 'json/builders/' + self.name, function(xhr) { Nit: Seems like "function(xhr) {" should be indented at the same level as the method below. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:90 > + }, > + function(xhr) { > + self._cache[cacheKey] = -1; > + callback(self._cache[cacheKey]); > + }); Nit: Is this code indented correctly?
Comment on attachment 94605 [details] Make TestFailures show how many tests are failing on each tester, and omit testers with no failures View in context: https://bugs.webkit.org/attachment.cgi?id=94605&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:90 >> + }); > > Nit: Is this code indented correctly? This is the style I've used elsewhere for calling functions that take multiple callbacks. I'm not sure it's ideal, but it does match the rest of this code.
Committed r87148: <http://trac.webkit.org/changeset/87148>