Bug 61520 - TestFailures page should take advantage of LocalStorage APIs (or similar) to improve loading performance
Summary: TestFailures page should take advantage of LocalStorage APIs (or similar) to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/TestFailures
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-26 06:23 PDT by Adam Roben (:aroben)
Modified: 2011-06-23 12:51 PDT (History)
0 users

See Also:


Attachments
Cache some of the TestFailures page's data in localStorage (14.41 KB, patch)
2011-06-23 12:33 PDT, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-05-26 06:23:04 PDT
The TestFailures page loads a bunch of data from build.webkit.org that doesn't change. If we were to cache some of this data in window.localStorage (or similar), we could avoid reloading the data every time the page is viewed by a particular user. This would probably speed up loading quite a bit.
Comment 1 Adam Roben (:aroben) 2011-05-26 06:27:57 PDT
Data we might want to cache:

1) The list of old builds for each tester
2) The set of failing tests in each of those old builds

We'd want to prune the cache from time to time. I think a strategy that would work well is:

* Whenever we finish finding revisions to blame for all currently failing tests, throw away all data for all revisions older than the oldest "passing" revision identified.

E.g., if all currently failing tests were passing in r12345, we could throw away all data for r12344 and older.
Comment 2 Adam Roben (:aroben) 2011-06-23 12:33:04 PDT
Created attachment 98381 [details]
Cache some of the TestFailures page's data in localStorage
Comment 3 David Kilzer (:ddkilzer) 2011-06-23 12:47:52 PDT
Comment on attachment 98381 [details]
Cache some of the TestFailures page's data in localStorage

r=me
Comment 4 Adam Roben (:aroben) 2011-06-23 12:51:18 PDT
Committed r89601: <http://trac.webkit.org/changeset/89601>