Bug 63807 - fast/loader/create-frame-in-DOMContentLoaded.html asserting in FrameLoader::loadWithDocumentLoader on Windows since it was added
Summary: fast/loader/create-frame-in-DOMContentLoaded.html asserting in FrameLoader::l...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/results/Windo...
Keywords: InRadar, LayoutTestFailure, Regression
Depends on:
Blocks:
 
Reported: 2011-07-01 08:42 PDT by Adam Roben (:aroben)
Modified: 2015-01-07 12:49 PST (History)
9 users (show)

See Also:


Attachments
Patch v1 (1.64 KB, patch)
2012-03-13 03:48 PDT, Mustafizur Rahaman( :rahaman)
no flags Details | Formatted Diff | Diff
Patch v2 (2.82 KB, patch)
2012-03-13 04:00 PDT, Mustafizur Rahaman( :rahaman)
japhet: review-
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-07-01 08:42:44 PDT
fast/loader/create-frame-in-DOMContentLoaded.html has been asserting in FrameLoader::loadWithDocumentLoader on Windows since it was added in r90038 <http://trac.webkit.org/changeset/90038>:

http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r90031%20(30136)/results.html passed
http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r90039%20(30140)/results.html failed
Comment 1 Adam Roben (:aroben) 2011-07-01 09:24:37 PDT
Added to the Windows Skipped file in r90236 http://trac.webkit.org/changeset/90236
Comment 2 Adam Roben (:aroben) 2011-07-01 09:25:37 PDT
<rdar://problem/9711373>
Comment 3 Darin Adler 2011-07-01 10:10:46 PDT
Thanks for adding to the skipped file. I am surprised this failed on Windows.
Comment 4 Mustafizur Rahaman( :rahaman) 2012-03-13 03:48:23 PDT
Created attachment 131585 [details]
Patch v1
Comment 5 Mustafizur Rahaman( :rahaman) 2012-03-13 03:56:00 PDT
Comment on attachment 131585 [details]
Patch v1

Will upload another patch with the test case being removed from Skipped list for Windows
Comment 6 Mustafizur Rahaman( :rahaman) 2012-03-13 04:00:48 PDT
Created attachment 131588 [details]
Patch v2
Comment 7 WebKit Review Bot 2012-03-13 04:36:24 PDT
Comment on attachment 131588 [details]
Patch v2

Attachment 131588 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11943480

New failing tests:
fast/events/form-iframe-target-before-load-crash2.html
fast/dom/Document/readystate.html
fast/loader/onload-policy-ignore-for-frame.html
fast/events/form-iframe-target-before-load-crash.html
Comment 8 Adam Roben (:aroben) 2012-03-13 09:57:44 PDT
Comment on attachment 131588 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=131588&action=review

> Source/WebCore/ChangeLog:13
> +        After creation of an initial document in Frame::init(),"load" event is triggered which is causing
> +        the problem. In accordance with the fix being made in https://bugs.webkit.org/show_bug.cgi?id=63483
> +        preventing "load" event being fired for initial document.

Do we know why this only affects Windows?
Comment 9 Nate Chapin 2012-04-19 16:02:52 PDT
Comment on attachment 131588 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=131588&action=review

This change seems strange to me, but the link to the build output is dead, so I'm short on context. Regardless, I'm pretty sure that this isn't the right place to exit for this particular case.

> Source/WebCore/loader/FrameLoader.cpp:715
> +    if (m_stateMachine.creatingInitialEmptyDocument())
> +        return;

It looks like this patch is causeing test failures (based on the cr-linux bot output). This seems like an overly broad place to do this check anyway. I would suggest trying it in Document::implicitClose().
Comment 10 Brent Fulgham 2015-01-07 12:49:07 PST
We no longer hit this problem with current WebKit.