WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
64192
It's hard to tell how many test-webkitpy/test-webkitperl tests failed when looking at build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=64192
Summary
It's hard to tell how many test-webkitpy/test-webkitperl tests failed when lo...
Adam Roben (:aroben)
Reported
2011-07-08 11:42:03 PDT
It's hard to tell how many test-webkitpy/test-webkitperl tests failed when looking at build.webkit.org
Attachments
Patch
(4.60 KB, patch)
2011-07-08 11:43 PDT
,
Adam Roben (:aroben)
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2011-07-08 11:43:11 PDT
Created
attachment 100141
[details]
Patch
Eric Seidel (no email)
Comment 2
2011-07-08 11:55:37 PDT
Comment on
attachment 100141
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=100141&action=review
Seems reasonable to me.
> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:393 > + regex = re.compile(r'^Failed \d+/\d+ test programs\. (?P<count>\d+)/\d+ subtests failed\.')
These regexps could be compile at class evaluation time instead of function execution time. Doubt it matters.
Eric Seidel (no email)
Comment 3
2011-07-08 11:56:05 PDT
You may want wms to check since he's more familiar with this file than I. But it looks like valid python that should do the job.
Adam Roben (:aroben)
Comment 4
2011-07-08 12:06:00 PDT
Committed
r90650
: <
http://trac.webkit.org/changeset/90650
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug