Lists of flaky revisions on TestFailures page can get so long they're hard to navigate
Created attachment 100163 [details] Patch
Comment on attachment 100163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:513 > + item.appendChild(document.createTextNode('\u22ee')); Nit: I would suggest either defining a const VerticalEllipsis = '\u22ee' or putting an inline comment here, like // Vertical ellipsis.
Comment on attachment 100163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:93 > + const startAndEndAbbreviatedExamplesCount = 3; The code also assumes that this is constant is always >= 1. Maybe we should have a comment to state this.
(In reply to comment #3) > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:93 > > + const startAndEndAbbreviatedExamplesCount = 3; > > The code also assumes that this is constant is always >= 1. Maybe we should have a comment to state this. I mean't to write that the constant must always be > 1.
Comment on attachment 100163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:93 >> + const startAndEndAbbreviatedExamplesCount = 3; > > The code also assumes that this is constant is always >= 1. Maybe we should have a comment to state this. Added a console.assert. >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:513 >> + item.appendChild(document.createTextNode('\u22ee')); > > Nit: I would suggest either defining a const VerticalEllipsis = '\u22ee' or putting an inline comment here, like // Vertical ellipsis. Done.
Committed r90682: <http://trac.webkit.org/changeset/90682>