Bug 64455 - TestFailures page doesn't show as much information for flaky tests as I would like, even though the page is already so long
Summary: TestFailures page doesn't show as much information for flaky tests as I would...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-13 08:26 PDT by Adam Roben (:aroben)
Modified: 2011-07-13 09:30 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.95 KB, patch)
2011-07-13 08:27 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-07-13 08:26:05 PDT 
TestFailures page doesn't show as much information for flaky tests as I would like, even though the page is already so long
Comment 1 Adam Roben (:aroben) 2011-07-13 08:27:08 PDT 
Created attachment 100676 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-07-13 08:38:10 PDT 
Comment on attachment 100676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100676&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:427
> +            var disclosureTriangle = document.createElement('span');
> +            item.appendChild(disclosureTriangle);
> +
> +            disclosureTriangle.className = 'disclosure-triangle';
> +            const blackRightPointingSmallTriangle = '\u25b8';
> +            disclosureTriangle.appendChild(document.createTextNode(blackRightPointingSmallTriangle));

you should totally try using details/summary here. If it doesn't work, we should fix bugs :)
Comment 3 WebKit Review Bot 2011-07-13 09:30:36 PDT 
Comment on attachment 100676 [details]
Patch

Clearing flags on attachment: 100676

Committed r90922: <http://trac.webkit.org/changeset/90922>
Comment 4 WebKit Review Bot 2011-07-13 09:30:40 PDT 
All reviewed patches have been landed.  Closing bug.