Created attachment 101635 [details] Patch Reviewed by NOBODY (OOPS!). * html/parser/create-html-entity-table: - Fix duplicate "EntityName" suffix on local variables (changes fooSemicolonEntityNameEntityName to fooSemicolonEntityName) for all 2138 symbols. - Add newlines to make source file human-readable (as originally intended). - Add static (const) keywords to local variables that are never referenced externally. --- 2 files changed, 25 insertions(+), 8 deletions(-)
Created attachment 101636 [details] Before
Created attachment 101637 [details] After
Attachment 101635 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 101635 [details] Patch LGTM.
Created attachment 101638 [details] Patch v2 - Added bug number. - Tweaked newlines to remove blank line after staticEntityTable and add newlines to uppercaseOffset and lowercaseOffset.
Comment on attachment 101638 [details] Patch v2 still LGTM.
Committed r91494: <http://trac.webkit.org/changeset/91494>
<rdar://problem/9818772>