Bug 64972 - Clean up generated HTMLEntityTable.cpp output
Summary: Clean up generated HTMLEntityTable.cpp output
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-07-21 12:58 PDT by David Kilzer (:ddkilzer)
Modified: 2011-07-21 15:30 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.93 KB, patch)
2011-07-21 12:58 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Before (309.03 KB, text/plain)
2011-07-21 12:59 PDT, David Kilzer (:ddkilzer)
no flags Details
After (286.15 KB, text/plain)
2011-07-21 12:59 PDT, David Kilzer (:ddkilzer)
no flags Details
Patch v2 (3.74 KB, patch)
2011-07-21 13:07 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-07-21 12:58:44 PDT
Created attachment 101635 [details]
Patch

Reviewed by NOBODY (OOPS!).

* html/parser/create-html-entity-table:
- Fix duplicate "EntityName" suffix on local variables (changes
fooSemicolonEntityNameEntityName to fooSemicolonEntityName)
for all 2138 symbols.
- Add newlines to make source file human-readable (as originally
intended).
- Add static (const) keywords to local variables that are never
referenced externally.
---
 2 files changed, 25 insertions(+), 8 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2011-07-21 12:59:21 PDT
Created attachment 101636 [details]
Before
Comment 2 David Kilzer (:ddkilzer) 2011-07-21 12:59:44 PDT
Created attachment 101637 [details]
After
Comment 3 WebKit Review Bot 2011-07-21 13:00:03 PDT
Attachment 101635 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Seidel (no email) 2011-07-21 13:06:39 PDT
Comment on attachment 101635 [details]
Patch

LGTM.
Comment 5 David Kilzer (:ddkilzer) 2011-07-21 13:07:36 PDT
Created attachment 101638 [details]
Patch v2

- Added bug number.
- Tweaked newlines to remove blank line after staticEntityTable and add newlines to uppercaseOffset and lowercaseOffset.
Comment 6 Eric Seidel (no email) 2011-07-21 13:08:27 PDT
Comment on attachment 101638 [details]
Patch v2

still LGTM.
Comment 7 David Kilzer (:ddkilzer) 2011-07-21 13:25:20 PDT
Committed r91494: <http://trac.webkit.org/changeset/91494>
Comment 8 David Kilzer (:ddkilzer) 2011-07-21 15:30:00 PDT
<rdar://problem/9818772>