[Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
Created attachment 101958 [details] Patch
Comment on attachment 101958 [details] Patch I don't really understand this patch. Why would you not just use the page group user sheets that are already being passed in? I don't like having yet another redundant user sheets vector.
Comment on attachment 101958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101958&action=review So basically just change userSheets to documentUserSheets in the CSSStyleSelector code. I think it's ok to use the generic m_userSheets in Document, since it's more clear over there that they are per-document. > Source/WebCore/css/CSSStyleSelector.cpp:432 > + CSSStyleSheet* pageUserSheet, const Vector<RefPtr<CSSStyleSheet> >* pageGroupUserSheets, const Vector<RefPtr<CSSStyleSheet> >* userSheets, Rename userSheets to documentUserSheets here. > Source/WebCore/css/CSSStyleSelector.cpp:489 > + if (userSheets) { Same here. Change userSheets to documentUserSheets. > Source/WebCore/css/CSSStyleSelector.h:93 > + CSSStyleSheet* pageUserSheet, const Vector<RefPtr<CSSStyleSheet> >* pageGroupUserSheets, const Vector<RefPtr<CSSStyleSheet> >* userSheets, Ditto.
Created attachment 102157 [details] Patch
(In reply to comment #3) > So basically just change userSheets to documentUserSheets in the CSSStyleSelector code. I think it's ok to use the generic m_userSheets in Document, since it's more clear over there that they are per-document. Done.
Comment on attachment 102157 [details] Patch r=me
Committed r91860: <http://trac.webkit.org/changeset/91860>