Bug 66302 - Apple's Windows port matches Lion for some test results, but doesn't use Lion results
Summary: Apple's Windows port matches Lion for some test results, but doesn't use Lion...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-16 07:58 PDT by Adam Roben (:aroben)
Modified: 2011-08-16 09:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.84 KB, patch)
2011-08-16 07:59 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Make Apple's Windows port fall back to Lion results instead of SnowLeopard (7.22 KB, patch)
2011-08-16 08:02 PDT, Adam Roben (:aroben)
ddkilzer: review+
aroben: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-08-16 07:58:26 PDT
Apple's Windows port matches Lion for some test results, but doesn't use Lion results
Comment 1 Adam Roben (:aroben) 2011-08-16 07:59:16 PDT
Created attachment 104042 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-08-16 08:02:40 PDT
Created attachment 104043 [details]
Make Apple's Windows port fall back to Lion results instead of SnowLeopard
Comment 3 David Kilzer (:ddkilzer) 2011-08-16 08:10:24 PDT
Comment on attachment 104043 [details]
Make Apple's Windows port fall back to Lion results instead of SnowLeopard

View in context: https://bugs.webkit.org/attachment.cgi?id=104043&action=review

r=me

> Tools/Scripts/webkitpy/common/config/build_unittest.py:43
> +        (["LayoutTests/platform/mac-lion/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]),

Nit: I would have sub-ordered the mac-* ports by release:  mac-leopard, mac-snowleopard, mac-lion, win
Comment 4 Adam Roben (:aroben) 2011-08-16 08:11:19 PDT
Comment on attachment 104043 [details]
Make Apple's Windows port fall back to Lion results instead of SnowLeopard

View in context: https://bugs.webkit.org/attachment.cgi?id=104043&action=review

>> Tools/Scripts/webkitpy/common/config/build_unittest.py:43
>> +        (["LayoutTests/platform/mac-lion/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]),
> 
> Nit: I would have sub-ordered the mac-* ports by release:  mac-leopard, mac-snowleopard, mac-lion, win

Everything else is sorted lexicographically. I think we might as well maintain that here, too. Silly Apple for not naming releases alphabetically!
Comment 5 Adam Roben (:aroben) 2011-08-16 09:03:27 PDT
Committed r93107: <http://trac.webkit.org/changeset/93107>