Bug 66309 - TestFailures thinks all tests passed in http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
Summary: TestFailures thinks all tests passed in http://build.webkit.org/builders/Lion...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-16 09:14 PDT by Adam Roben (:aroben)
Modified: 2011-08-16 09:28 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.60 KB, patch)
2011-08-16 09:14 PDT, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-08-16 09:14:16 PDT
TestFailures thinks all tests passed in http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
Comment 1 Adam Roben (:aroben) 2011-08-16 09:14:53 PDT
Created attachment 104055 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2011-08-16 09:21:27 PDT
Comment on attachment 104055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104055&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:183
> +test("getNumberOfFailingTests treats unfinished test runs  as errors", 4, function() {

Nit:  Extra space between "runs  as".
Comment 3 Adam Roben (:aroben) 2011-08-16 09:26:31 PDT
Comment on attachment 104055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104055&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:183
>> +test("getNumberOfFailingTests treats unfinished test runs  as errors", 4, function() {
> 
> Nit:  Extra space between "runs  as".

Fixed.
Comment 4 Adam Roben (:aroben) 2011-08-16 09:28:59 PDT
Committed r93111: <http://trac.webkit.org/changeset/93111>