Bug 68621 - build-webkit goes totally haywire on Windows if there are spaces in the path to the WebKit source tree
Summary: build-webkit goes totally haywire on Windows if there are spaces in the path ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-09-22 08:20 PDT by Adam Roben (:aroben)
Modified: 2011-09-22 10:51 PDT (History)
1 user (show)

See Also:


Attachments
Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath (1.40 KB, patch)
2011-09-22 08:23 PDT, Adam Roben (:aroben)
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-09-22 08:20:47 PDT
To reproduce:

1. Check out WebKit to some location that has spaces in its path
2. build-webkit

You'll get all sorts of funky errors from Visual Studio.
Comment 1 Adam Roben (:aroben) 2011-09-22 08:23:24 PDT
Created attachment 108337 [details]
Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
Comment 2 Adam Roben (:aroben) 2011-09-22 10:51:26 PDT
Committed r95731: <http://trac.webkit.org/changeset/95731>