Bug 69575 - Extract WebOpenPanelResultListener out into its own file
Summary: Extract WebOpenPanelResultListener out into its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 15:30 PDT by Joseph Pecoraro
Modified: 2011-10-10 15:06 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Extract WebOpenPanelListener into its own file (13.27 KB, patch)
2011-10-06 16:56 PDT, Joseph Pecoraro 		ddkilzer: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-10-06 15:30:56 PDT 
Extract WebOpenPanelResultListener out into its own file.
Comment 1 Joseph Pecoraro 2011-10-06 16:56:47 PDT 
Created attachment 110061 [details]
[PATCH] Extract WebOpenPanelListener into its own file

• Copyright (C) 2008 Apple Inc. since that is when the code was added and it hasn't really changed since.
• I added some missing forward declarations to WebUIDelegate.h. That is a Public API header. Does this need special consideration?
Comment 2 Joseph Pecoraro 2011-10-06 16:57:46 PDT 
Extracting the code from WebView.mm I was able to combine an ENABLE(FULLSCREEN)
block above it and below it. In case you were wondering what those were.
Comment 3 WebKit Review Bot 2011-10-06 16:59:39 PDT 
Attachment 110061 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1

Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:34:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 David Kilzer (:ddkilzer) 2011-10-10 12:26:50 PDT 
Comment on attachment 110061 [details]
[PATCH] Extract WebOpenPanelListener into its own file

View in context: https://bugs.webkit.org/attachment.cgi?id=110061&action=review

>> Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:30
>> +    class FileChooser;
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

This one should be fixed.

>> Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:34
>> +{
> 
> This { should be at the end of the previous line  [whitespace/braces] [4]

I think this one can be ignored.
Comment 5 David Kilzer (:ddkilzer) 2011-10-10 12:27:53 PDT 
(In reply to comment #1)
> • I added some missing forward declarations to WebUIDelegate.h. That is a Public API header. Does this need special consideration?

Nope.  Those are public classes, so I don't see any problem with adding @class declarations for them.
Comment 6 Joseph Pecoraro 2011-10-10 15:06:23 PDT 
> >> Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:30
> >> +    class FileChooser;
> > 
> > Code inside a namespace should not be indented.  [whitespace/indent] [4]
> 
> This one should be fixed.

Done.
Comment 7 Joseph Pecoraro 2011-10-10 15:06:38 PDT 
Landed in r97095 <http://trac.webkit.org/changeset/97095>.