Bug 71679 - Don't use CSSOM's CSSValue.cssValueType internally in WebCore.
Summary: Don't use CSSOM's CSSValue.cssValueType internally in WebCore.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-07 06:26 PST by Andreas Kling
Modified: 2011-11-07 11:21 PST (History)
4 users (show)

See Also:

Attachments
Patch (18.54 KB, patch)
2011-11-07 06:33 PST, Andreas Kling 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-07 06:26:42 PST 
This method is grainy and granular. We should use the more explicit isPrimitiveValue() and friends.
We'll need to add isInitialValue() and isInheritedValue() for this.
They will be temporarily virtual until <http://webkit.org/b/71666> kicks in.
Comment 1 Andreas Kling 2011-11-07 06:33:04 PST 
Created attachment 113857 [details]
Patch
Comment 2 Darin Adler 2011-11-07 10:52:51 PST 
Comment on attachment 113857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113857&action=review

> Source/WebCore/ChangeLog:3
> +        Don't use CSSOM's CSSValue.cssValueType internally in WebCore.

You should say why. I presume because it’s slow? Or maybe unclear?
Comment 3 Andreas Kling 2011-11-07 11:21:15 PST 
Committed r99450: <http://trac.webkit.org/changeset/99450>