Bug 71796 - CSSCanvasValue: Remove inheritance from CanvasObserver.
Summary: CSSCanvasValue: Remove inheritance from CanvasObserver.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks: 71666
  Show dependency tree / graph
 
Reported: 2011-11-08 04:29 PST by Andreas Kling
Modified: 2011-11-08 05:22 PST (History)
3 users (show)

See Also:

Attachments
Proposed patch (4.17 KB, patch)
2011-11-08 04:38 PST, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-08 04:29:36 PST 
In order to remove the vptr from CSSCanvasValue, we need to remove the inheritance from CanvasObserver.
I plan to do this in the same was as CSSImportRule, by adding a proxying observer as a member variable.
Comment 1 Andreas Kling 2011-11-08 04:38:54 PST 
Created attachment 114040 [details]
Proposed patch
Comment 2 Antti Koivisto 2011-11-08 04:59:55 PST 
Comment on attachment 114040 [details]
Proposed patch

r=me
Comment 3 Andreas Kling 2011-11-08 05:22:26 PST 
Committed r99555: <http://trac.webkit.org/changeset/99555>