Bug 71923 - Shrink StyleSheet on 64-bit.
Summary: Shrink StyleSheet on 64-bit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 09:02 PST by Andreas Kling
Modified: 2011-11-09 10:03 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.31 KB, patch)
2011-11-09 09:04 PST, Andreas Kling
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-09 09:02:59 PST
Won't hurt.
Comment 1 Andreas Kling 2011-11-09 09:04:55 PST
Created attachment 114298 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-09 09:07:34 PST
Attachment 114298 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/css/StyleSheet.h:41:  The parameter name "disabled" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2011-11-09 09:10:27 PST
Comment on attachment 114298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114298&action=review

>> Source/WebCore/css/StyleSheet.h:41
>> +    void setDisabled(bool disabled);
> 
> The parameter name "disabled" adds no information, so it should be removed.  [readability/parameter_name] [5]

Ehrm. Not sure how I managed to add this. Please disregard! :)
Comment 4 Andreas Kling 2011-11-09 10:03:39 PST
Committed r99730: <http://trac.webkit.org/changeset/99730>