Bug 72502 - CSSValue: Clean up initial value construction.
Summary: CSSValue: Clean up initial value construction.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-16 06:45 PST by Andreas Kling
Modified: 2011-11-21 06:38 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.61 KB, patch)
2011-11-16 07:07 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-16 06:45:07 PST 
We currently determine whether a CSSInitialValue is "implicit" or not based on its CSSValue::ClassType at construction.
We should move this to a CSSValue bit instead to make the code a little less horrible.
Comment 1 Andreas Kling 2011-11-16 07:07:00 PST 
Created attachment 115375 [details]
Patch
Comment 2 Antti Koivisto 2011-11-16 07:10:16 PST 
Comment on attachment 115375 [details]
Patch

Yeah, seems cleaner. r=me.
Comment 3 WebKit Review Bot 2011-11-16 07:49:28 PST 
Comment on attachment 115375 [details]
Patch

Clearing flags on attachment: 115375

Committed r100449: <http://trac.webkit.org/changeset/100449>
Comment 4 WebKit Review Bot 2011-11-16 07:49:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Luke Macpherson 2011-11-17 18:35:27 PST 
Isn't this worse? m_implicit as a separate bit no longer communicates that only InitialClass can be implicit, and now costs a full bit rather than being one value of many in m_classType.
Comment 6 Andreas Kling 2011-11-21 06:38:43 PST 
(In reply to comment #5)
> Isn't this worse? m_implicit as a separate bit no longer communicates that only InitialClass can be implicit, and now costs a full bit rather than being one value of many in m_classType.

I actually plan to remove both CSSInitialValue and CSSInheritedValue and move their representation into CSSValue.