Bug 73501 - StyledElement: Tidy up copyNonAttributeProperties().
Summary: StyledElement: Tidy up copyNonAttributeProperties().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-30 16:58 PST by Andreas Kling
Modified: 2011-12-01 07:20 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.63 KB, patch)
2011-11-30 17:05 PST, Andreas Kling
koivisto: review+
koivisto: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-30 16:58:44 PST
As a follow-up to bug 73227 (landed in r101502), we should tidy up copyNonAttributeProperties() a bit, redo CSSMutableStyleDeclaration's copyPropertiesAndStrictnessFrom() as copyPropertiesFrom(), and make the style declarations non-copyable.
Comment 1 Andreas Kling 2011-11-30 17:05:07 PST
Created attachment 117301 [details]
Patch
Comment 2 Antti Koivisto 2011-12-01 02:29:52 PST
Comment on attachment 117301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117301&action=review

> Source/WebCore/css/CSSInlineStyleDeclaration.h:35
>  class CSSInlineStyleDeclaration : public CSSElementStyleDeclaration {
> +    WTF_MAKE_NONCOPYABLE(CSSInlineStyleDeclaration);

I think it is sufficient to have this in the base class (some other instances here too).
Comment 3 Andreas Kling 2011-12-01 07:20:13 PST
Committed r101665: <http://trac.webkit.org/changeset/101665>