Bug 73564 - CSSMutableStyleDeclaration: Unnecessary double hash lookup in construction.
Summary: CSSMutableStyleDeclaration: Unnecessary double hash lookup in construction.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-01 08:08 PST by Andreas Kling
Modified: 2011-12-01 12:04 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2011-12-01 08:16 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-01 08:08:37 PST
In this constructor:

- CSSMutableStyleDeclaration(CSSRule* parent, const CSSProperty* const * properties, int numProperties)

We do a hash lookup using contains(), followed by a get() if contains() returns true. This should be done with a single lookup.
Comment 1 Andreas Kling 2011-12-01 08:16:39 PST
Created attachment 117424 [details]
Patch
Comment 2 Antti Koivisto 2011-12-01 10:54:41 PST
Comment on attachment 117424 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2011-12-01 12:04:42 PST
Comment on attachment 117424 [details]
Patch

Clearing flags on attachment: 117424

Committed r101697: <http://trac.webkit.org/changeset/101697>
Comment 4 WebKit Review Bot 2011-12-01 12:04:47 PST
All reviewed patches have been landed.  Closing bug.