Bug 73732 - Shrink CSSValueList.
Summary: Shrink CSSValueList.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-02 19:53 PST by Andreas Kling
Modified: 2011-12-06 15:01 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2011-12-02 19:54 PST, Andreas Kling
koivisto: review+
koivisto: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-02 19:53:08 PST
Shrink CSSValueList.
Comment 1 Andreas Kling 2011-12-02 19:54:31 PST
Created attachment 117736 [details]
Patch
Comment 2 Antti Koivisto 2011-12-03 02:47:02 PST
Comment on attachment 117736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117736&action=review

> Source/WebCore/css/CSSValue.h:181
>      // CSSInitialValue bits:
>      bool m_isImplicit : 1;
>  
> +    // CSSValueList bits:
> +    bool m_isSpaceSeparated : 1;

m_isSpaceSeparatedValueList etc perhaps?
Comment 3 Andreas Kling 2011-12-03 04:20:39 PST
Committed r101924: <http://trac.webkit.org/changeset/101924>
Comment 4 Luke Macpherson 2011-12-06 15:01:43 PST
It would be good to also add COMPILE_ASSERTS to help prevent regressing the size of these types in the future.