Bug 73761 - Use HashMap<OwnPtr> for EventListenerMap's internal map.
Summary: Use HashMap<OwnPtr> for EventListenerMap's internal map.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-03 21:28 PST by Andreas Kling
Modified: 2011-12-06 00:22 PST (History)
0 users

See Also:


Attachments
Patch (5.57 KB, patch)
2011-12-03 21:31 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-03 21:28:33 PST
Use HashMap<OwnPtr> for EventListenerMap's internal map.
Comment 1 Andreas Kling 2011-12-03 21:31:17 PST
Created attachment 117781 [details]
Patch
Comment 2 Benjamin Poulain 2011-12-06 00:06:58 PST
Comment on attachment 117781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117781&action=review

Nice

> Source/WebCore/dom/EventListenerMap.cpp:-79
> -    if (m_hashMap) {
> -        deleteAllValues(*m_hashMap);
> +    if (m_hashMap)
>          m_hashMap.clear();
> -    } else {

Here your patch does two things: fix the style && change the code.
You should make a separate patch for the style fix, then apply your hash map fix... :-D
Comment 3 Andreas Kling 2011-12-06 00:09:38 PST
(In reply to comment #2)
> (From update of attachment 117781 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117781&action=review
> 
> Nice
> 
> > Source/WebCore/dom/EventListenerMap.cpp:-79
> > -    if (m_hashMap) {
> > -        deleteAllValues(*m_hashMap);
> > +    if (m_hashMap)
> >          m_hashMap.clear();
> > -    } else {
> 
> Here your patch does two things: fix the style && change the code.
> You should make a separate patch for the style fix, then apply your hash map fix... :-D

... Sorry, brah. It won't happen again :)
Comment 4 Andreas Kling 2011-12-06 00:21:50 PST
Comment on attachment 117781 [details]
Patch

Clearing flags on attachment: 117781

Committed r102106: <http://trac.webkit.org/changeset/102106>
Comment 5 Andreas Kling 2011-12-06 00:22:00 PST
All reviewed patches have been landed.  Closing bug.