Bug 73793 - CSSStyleSheet can't be reparented, enforce this at compile time.
Summary: CSSStyleSheet can't be reparented, enforce this at compile time.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-04 19:17 PST by Andreas Kling
Modified: 2011-12-04 21:44 PST (History)
2 users (show)

See Also:


Attachments
Patch (7.30 KB, patch)
2011-12-04 20:52 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-04 19:17:16 PST
We should replace CSSStyleSheet's setParentRule() by clearParentRule() to enforce the fact that CSSStyleSheet can't be moved to another parent rule after creation.
Comment 1 Andreas Kling 2011-12-04 20:52:11 PST
Created attachment 117835 [details]
Patch
Comment 2 Benjamin Poulain 2011-12-04 21:26:01 PST
Comment on attachment 117835 [details]
Patch

The pach looks good. I am unfamiliar with the naming preference owner/parentRule but that seem consistent with CSSOM.
Comment 3 Andreas Kling 2011-12-04 21:44:08 PST
Comment on attachment 117835 [details]
Patch

Clearing flags on attachment: 117835

Committed r101972: <http://trac.webkit.org/changeset/101972>
Comment 4 Andreas Kling 2011-12-04 21:44:16 PST
All reviewed patches have been landed.  Closing bug.