Bug 73888 - REGRESSION (WebKit2): Kill ring is not cleared when selection changes
Summary: REGRESSION (WebKit2): Kill ring is not cleared when selection changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-12-05 21:24 PST by Alexey Proskuryakov
Modified: 2011-12-06 10:55 PST (History)
4 users (show)

See Also:


Attachments
proposed fix (5.96 KB, patch)
2011-12-05 21:39 PST, Alexey Proskuryakov
mrowe: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-12-05 21:24:18 PST
Pressing Ctrl+K twice should only add to kill ring if nothing else happens in between.

<rdar://problem/10532310>
Comment 1 Alexey Proskuryakov 2011-12-05 21:39:35 PST
Created attachment 117988 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2011-12-05 21:41:25 PST
Comment on attachment 117988 [details]
proposed fix

Landing via commit queue to give bots time to complain.
Comment 3 WebKit Review Bot 2011-12-05 21:58:00 PST
Comment on attachment 117988 [details]
proposed fix

Attachment 117988 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10736565
Comment 4 Alexey Proskuryakov 2011-12-05 23:03:11 PST
> Attachment 117988 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/10736565

The error doesn't appear related to this patch.
Comment 5 WebKit Review Bot 2011-12-06 01:59:13 PST
Comment on attachment 117988 [details]
proposed fix

Rejecting attachment 117988 [details] from commit-queue.

New failing tests:
editing/pasteboard/emacs-ctrl-k-with-move.html
Full output: http://queues.webkit.org/results/10733906
Comment 6 Alexey Proskuryakov 2011-12-06 09:38:07 PST
Committed <http://trac.webkit.org/changeset/102148>. Added the new test to fail lists of platforms that failed existing emacs tests.