Bug 74248 - Remove OS(SYMBIAN) block from Settings constructor.
Summary: Remove OS(SYMBIAN) block from Settings constructor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-10 16:38 PST by Andreas Kling
Modified: 2011-12-11 11:34 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.17 KB, patch)
2011-12-10 16:40 PST, Andreas Kling
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-10 16:38:32 PST
SSIA
Comment 1 Andreas Kling 2011-12-10 16:40:51 PST
Created attachment 118699 [details]
Patch
Comment 2 Benjamin Poulain 2011-12-10 18:54:45 PST
Comment on attachment 118699 [details]
Patch

I am ok with this particular change but do you know why we have passwordEchoEnabled at all? Maybe we can remove that setting entierly?
Comment 3 Benjamin Poulain 2011-12-10 19:06:31 PST
Ok, that was added in 93656.

This code comes from iOS, so it makes sense to keep it.
Comment 4 Andreas Kling 2011-12-11 11:34:15 PST
Committed r102539: <http://trac.webkit.org/changeset/102539>