Bug 74256 - Move CSSElementStyleDeclaration to its own cpp/h files.
Summary: Move CSSElementStyleDeclaration to its own cpp/h files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-11 11:56 PST by Andreas Kling
Modified: 2011-12-11 15:08 PST (History)
2 users (show)

See Also:

Attachments
Patch (16.60 KB, patch)
2011-12-11 12:00 PST, Andreas Kling 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-11 11:56:48 PST 
SSIA
Comment 1 Andreas Kling 2011-12-11 12:00:13 PST 
Created attachment 118709 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-11 12:06:03 PST 
Attachment 118709 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/css/CSSElementStyleDeclaration.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2011-12-11 12:41:06 PST 
Comment on attachment 118709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118709&action=review

>> Source/WebCore/css/CSSElementStyleDeclaration.cpp:27
>> +#include "CSSElementStyleDeclaration.h"
> 
> You should add a blank line after implementation file's own header.  [build/include_order] [4]

Do as the bot commands, add a blank line.

> Source/WebCore/css/CSSElementStyleDeclaration.h:35
> +class CSSElementStyleDeclaration : public CSSMutableStyleDeclaration {

It might be worth adding a comment about why this class exists, since only a derived class can instantiate it.
Comment 4 Andreas Kling 2011-12-11 15:08:09 PST 
Committed r102543: <http://trac.webkit.org/changeset/102543>