SSIA
Created attachment 118709 [details] Patch
Attachment 118709 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/css/CSSElementStyleDeclaration.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 118709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118709&action=review >> Source/WebCore/css/CSSElementStyleDeclaration.cpp:27 >> +#include "CSSElementStyleDeclaration.h" > > You should add a blank line after implementation file's own header. [build/include_order] [4] Do as the bot commands, add a blank line. > Source/WebCore/css/CSSElementStyleDeclaration.h:35 > +class CSSElementStyleDeclaration : public CSSMutableStyleDeclaration { It might be worth adding a comment about why this class exists, since only a derived class can instantiate it.
Committed r102543: <http://trac.webkit.org/changeset/102543>