Bug 74378 - CollectionCache: Remove unused copy constructor and make it noncopyable.
Summary: CollectionCache: Remove unused copy constructor and make it noncopyable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-12 19:10 PST by Andreas Kling
Modified: 2011-12-13 04:03 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.10 KB, patch)
2011-12-12 19:16 PST, Andreas Kling 		hausmann: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-12 19:10:38 PST 
Nobody is using the CollectionCache copy constructor or associated methods swap() and copyCacheMap(). Let's remove them and make the class noncopyable.
Comment 1 Andreas Kling 2011-12-12 19:16:12 PST 
Created attachment 118934 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-12 19:17:45 PST 
Attachment 118934 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/html/CollectionCache.h:33:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Hausmann 2011-12-13 00:22:13 PST 
Comment on attachment 118934 [details]
Patch

Yay for removal of dead code :)
Comment 4 Andreas Kling 2011-12-13 04:03:48 PST 
Committed r102669: <http://trac.webkit.org/changeset/102669>